Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix proxy setting when ratelimit is 0 #402

Merged
merged 2 commits into from
Aug 8, 2024

Conversation

AaronChen0
Copy link
Contributor

@AaronChen0 AaronChen0 commented Jul 31, 2024

Fix #403

Changes I make:

  1. defaultTransport should be used when ratelimit is 0.
  2. Add info about notify socks5 proxy support. net.http.Transport supports both http and socks5 proxy. Tested. Really works.

@GeorginaReeder
Copy link

Thanks for your contribution @AaronChen0 !

We also have a Discord server, which you’re more than welcome to join. It's a great place to connect with fellow contributors and stay updated with the latest developments!

@ehsandeep ehsandeep changed the base branch from main to dev August 1, 2024 16:33
@ehsandeep ehsandeep requested a review from dwisiswant0 August 1, 2024 16:34
@dwisiswant0
Copy link
Member

Could you please create the issue first, @AaronChen0?

README.md Outdated Show resolved Hide resolved
cmd/notify/notify.go Outdated Show resolved Hide resolved
internal/runner/runner.go Outdated Show resolved Hide resolved
@AaronChen0 AaronChen0 requested a review from dwisiswant0 August 2, 2024 03:23
Copy link
Member

@dwisiswant0 dwisiswant0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@AaronChen0
Copy link
Contributor Author

The failed check is irrelevant to this pull request.

Switching branch from main to dev introduced a commit not by me. Is this a concern when later dev branch merges back to main branch?

@dwisiswant0
Copy link
Member

@AaronChen0 - you should rebase your branch.

@AaronChen0
Copy link
Contributor Author

@dwisiswant0. Rebase done.

@AaronChen0 AaronChen0 requested a review from dwisiswant0 August 6, 2024 08:29
@ehsandeep ehsandeep linked an issue Aug 8, 2024 that may be closed by this pull request
@ehsandeep ehsandeep merged commit a1964d9 into projectdiscovery:dev Aug 8, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

proxy not working when ratelimit is 0
4 participants